Add 3.0.0 osd test manifest #3477
Conversation
Signed-off-by: Divya Madala <[email protected]>
Divyaasm
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
tianleh
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3477 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 181 181
Lines 5331 5331
=======================================
Hits 4859 4859
Misses 472 472 |
| integ-test: | ||
| test-configs: | ||
| - with-security | ||
| - without-security |
There was a problem hiding this comment.
I dont think securityDashboards will have tests without-security. Can you confirm?
There was a problem hiding this comment.
Tagging security dashboards maintainers: @cwperks @peternied @davidlago
There was a problem hiding this comment.
I'm not sure how these tests are being sourced, this file looks different from 2.7.0 version, https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.7.0/opensearch-dashboards-2.7.0-test.yml , has there been changes to the architecture?
There are security tests in the functionalTestDashboards repo, which allows for running with and without security enabled.
There was a problem hiding this comment.
Yes the architecture is changing. Thanks for asking this. Looks like we need to add documentation for new architecture! @Divyaasm Can you take this question up and also later take care of adding the documentation ?
There was a problem hiding this comment.
Yes @peternied , we have recently updated the implemention for OSD integtests, this used to run in a sequential order for all the OSD component plugins listed in ftrepo based on functionalTestDashboards input earlier. Now OSD integtest works similar to OS intgtests. Refer the related PR's #3316 and #3465 to get an idea on the implementation changes.
We will now be able to to run this individually for each OSD component or all together at once in parallel from Jenkins perspective and update results individually for each component in the S3 bucket based on the updated test manifest similar to the current PR. Let me know if you have any questions.
This PR is just used to test the latest implementation from Prod Jenkins.
Thanks,
Divya Madala
There was a problem hiding this comment.
OK, well please go ahead and include the tests as has been done with other plugins. I am not certain this is correct, but I think its best to move forward with generation results than waiting on making a determination
gaiksaya
dismissed
their stale review
Need to confirm changes for securityDashboards
Description
This PR adds OSD componets for 3.0.0 test manifest
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.